starknet_transaction_prover: add ServiceConfig validation tests#14049
starknet_transaction_prover: add ServiceConfig validation tests#14049avi-starkware wants to merge 1 commit into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview CORS: The single path-rejection test becomes an New cases: Missing Reviewed by Cursor Bugbot for commit 38dd27c. Bugbot is set up for automated code reviews on this repo. Configure here. |
3bf5954 to
8600ded
Compare
8aa40a1 to
b5dba94
Compare
8600ded to
96bf8d9
Compare
9636c86 to
20c98e9
Compare
96bf8d9 to
056f406
Compare
20c98e9 to
d437078
Compare
056f406 to
3a5608b
Compare
Adds unit tests for ServiceConfig::from_args covering: missing rpc_url rejection, zero max_concurrent_requests / max_connections rejection, mutual exclusion of --no-cors and --cors-allow-origin, --no-cors clearing config-file origins, --skip-fee-field-validation propagating to ProverConfig, config-file values being used when CLI flags are absent, CLI flags overriding config-file values, and additional CORS scheme/userinfo rejection at the config layer.
d437078 to
8342ce5
Compare
3a5608b to
38dd27c
Compare

Adds unit tests for ServiceConfig::from_args covering: missing rpc_url
rejection, zero max_concurrent_requests / max_connections rejection,
mutual exclusion of --no-cors and --cors-allow-origin, --no-cors
clearing config-file origins, --skip-fee-field-validation propagating
to ProverConfig, config-file values being used when CLI flags are
absent, CLI flags overriding config-file values, and additional CORS
scheme/userinfo rejection at the config layer.